Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepgatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
codeowners.test.ts4.6 KB · 144 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
/**
 * Tests for src/lib/codeowners.ts's `requiredOwnersApproved()` — the fix for
 * CODEOWNERS approval being advisory-only. Before this, `reviewersForChangedFiles()`
 * was only used to auto-*request* reviewers on PR open; nothing at merge time
 * checked whether a CODEOWNERS-designated reviewer actually approved.
 *
 * `getCodeownersForRepo` and `loadApprovedUsernames` are passed in via the
 * injectable `deps` param (same DI rationale as push-workflow-sync.ts /
 * pr-workflow-sync.ts): the real implementations touch ../git/repository and
 * ../db respectively, both imported by dozens of unrelated test files, so a
 * global mock.module() on either would leak across the whole `bun test` run.
 * `matchOwners` / `expandOwnerTokens` (pure + already covered by
 * green-ecosystem.test.ts) run for real — only usernames (no team tokens)
 * are used here so `expandOwnerTokens` never touches the DB.
 */

import { describe, expect, it } from "bun:test";
import { requiredOwnersApproved } from "../lib/codeowners";
import type { OwnerRule } from "../lib/codeowners";

function deps(rules: OwnerRule[], approved: Set<string>) {
  return {
    getCodeownersForRepo: async () => rules,
    loadApprovedUsernames: async () => approved,
  };
}

describe("requiredOwnersApproved", () => {
  it("is satisfied when there is no CODEOWNERS file", async () => {
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      deps([], new Set())
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });

  it("is satisfied when CODEOWNERS exists but matches none of the changed files", async () => {
    const rules: OwnerRule[] = [{ pattern: "docs/**", owners: ["alice"] }];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      deps(rules, new Set())
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });

  it("blocks when the required owner has not approved", async () => {
    const rules: OwnerRule[] = [{ pattern: "src/api/**", owners: ["alice"] }];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      deps(rules, new Set())
    );
    expect(result.satisfied).toBe(false);
    expect(result.missingOwners).toEqual(["alice"]);
  });

  it("is satisfied when the required owner has approved", async () => {
    const rules: OwnerRule[] = [{ pattern: "src/api/**", owners: ["alice"] }];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      deps(rules, new Set(["alice"]))
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });

  it("reports only the owners who haven't approved out of several", async () => {
    const rules: OwnerRule[] = [
      { pattern: "src/api/**", owners: ["alice", "bob"] },
    ];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      deps(rules, new Set(["alice"]))
    );
    expect(result.satisfied).toBe(false);
    expect(result.missingOwners).toEqual(["bob"]);
  });

  it("fails open (satisfied: true) when getCodeownersForRepo throws", async () => {
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      {
        getCodeownersForRepo: async () => {
          throw new Error("git boom");
        },
        loadApprovedUsernames: async () => new Set(),
      }
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });

  it("fails open (satisfied: true) when loadApprovedUsernames throws", async () => {
    const rules: OwnerRule[] = [{ pattern: "src/api/**", owners: ["alice"] }];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/api/foo.ts"],
      {
        getCodeownersForRepo: async () => rules,
        loadApprovedUsernames: async () => {
          throw new Error("db boom");
        },
      }
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });

  it("is satisfied when no files changed match any rule across multiple paths", async () => {
    const rules: OwnerRule[] = [{ pattern: "/docs", owners: ["carol"] }];
    const result = await requiredOwnersApproved(
      "acme",
      "widgets",
      "main",
      "pr-1",
      ["src/a.ts", "src/b.ts"],
      deps(rules, new Set())
    );
    expect(result).toEqual({ satisfied: true, missingOwners: [] });
  });
});