Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepgatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
push-policy.test.ts4.0 KB · 123 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
/**
 * Tests for src/lib/push-policy.ts.
 *
 * The DB-touching paths (matchProtectedTag, listRulesetsForRepo,
 * canBypassProtectedTag) require a live DB; we don't have one in unit
 * tests. Instead we cover:
 *
 *   - The pure formatPolicyError formatter — exhaustive.
 *   - The fail-open guarantee on bad input (empty refs, missing repo id).
 *   - Module shape (imports don't throw, expected exports are present).
 *
 * Real end-to-end coverage of the policy decisions runs in the existing
 * rulesets + protected-tags test suites (which exercise evaluatePush and
 * matchGlob directly). This file verifies that the new wrapper preserves
 * fail-open semantics, which is the property that protects production
 * pushes from a Postgres hiccup.
 */

import { describe, it, expect } from "bun:test";
import {
  evaluatePushPolicy,
  formatPolicyError,
  ZERO_SHA,
} from "../lib/push-policy";

describe("ZERO_SHA constant", () => {
  it("is exactly 40 zeros", () => {
    expect(ZERO_SHA).toBe("0000000000000000000000000000000000000000");
    expect(ZERO_SHA.length).toBe(40);
  });
});

describe("formatPolicyError", () => {
  it("returns a generic message when violations is empty", () => {
    expect(formatPolicyError([])).toBe("Push rejected by Gluecron policy.");
  });

  it("returns a generic message when violations is null/undefined", () => {
    expect(formatPolicyError(null as any)).toBe(
      "Push rejected by Gluecron policy."
    );
    expect(formatPolicyError(undefined as any)).toBe(
      "Push rejected by Gluecron policy."
    );
  });

  it("renders one violation as a bulleted list", () => {
    const out = formatPolicyError(['tag "v1.0" is protected']);
    expect(out).toContain("Push rejected by Gluecron policy:");
    expect(out).toContain(' - tag "v1.0" is protected');
  });

  it("renders multiple violations on separate lines", () => {
    const out = formatPolicyError([
      'tag "v1.0" is protected',
      'ruleset "no-prod-pushes" rule branch_name_pattern: blocked',
    ]);
    const lines = out.trimEnd().split("\n");
    expect(lines[0]).toBe("Push rejected by Gluecron policy:");
    expect(lines[1]).toBe(' - tag "v1.0" is protected');
    expect(lines[2]).toBe(
      ' - ruleset "no-prod-pushes" rule branch_name_pattern: blocked'
    );
  });

  it("ends with a newline (so git surfaces the body cleanly)", () => {
    expect(formatPolicyError(["one violation"]).endsWith("\n")).toBe(true);
  });
});

describe("evaluatePushPolicy — fail-open on bad input", () => {
  it("returns allowed=true for an empty refs list", async () => {
    const r = await evaluatePushPolicy({
      repositoryId: "repo-1",
      refs: [],
      pusherUserId: null,
    });
    expect(r.allowed).toBe(true);
    expect(r.violations).toEqual([]);
  });

  it("returns allowed=true for missing repositoryId", async () => {
    const r = await evaluatePushPolicy({
      repositoryId: "" as any,
      refs: [
        {
          oldSha: ZERO_SHA,
          newSha: "a".repeat(40),
          refName: "refs/tags/v1.0",
        },
      ],
      pusherUserId: null,
    });
    expect(r.allowed).toBe(true);
  });

  it("returns allowed=true when DB is unreachable (refs target a nonexistent repo)", async () => {
    // No real repo exists with id "definitely-not-a-real-repo-id"; the
    // matchProtectedTag + listRulesetsForRepo callers catch their own
    // errors and return empty arrays, so the wrapper returns allowed.
    const r = await evaluatePushPolicy({
      repositoryId: "definitely-not-a-real-repo-id",
      refs: [
        {
          oldSha: ZERO_SHA,
          newSha: "a".repeat(40),
          refName: "refs/heads/main",
        },
      ],
      pusherUserId: null,
    });
    expect(r.allowed).toBe(true);
  });
});

describe("evaluatePushPolicy — module shape", () => {
  it("exports the functions the route depends on", async () => {
    const mod = await import("../lib/push-policy");
    expect(typeof mod.evaluatePushPolicy).toBe("function");
    expect(typeof mod.formatPolicyError).toBe("function");
    expect(typeof mod.ZERO_SHA).toBe("string");
  });
});