1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
|
import { describe, expect, test } from "bun:test";
import { evaluateProtection } from "../lib/branch-protection";
import type { BranchProtection } from "../db/schema";
function rule(overrides: Partial<BranchProtection>): BranchProtection {
return {
id: "id",
repositoryId: "repo",
pattern: "main",
requirePullRequest: true,
requireGreenGates: false,
requireAiApproval: false,
requireHumanReview: false,
requiredApprovals: 0,
allowForcePush: false,
allowDeletion: false,
dismissStaleReviews: true,
createdAt: new Date(),
updatedAt: new Date(),
...overrides,
} as BranchProtection;
}
describe("evaluateProtection", () => {
test("no rule → allowed with no reasons", () => {
const r = evaluateProtection(null, {
aiApproved: false,
humanApprovalCount: 0,
gateResultGreen: false,
hasFailedGates: true,
});
expect(r.allowed).toBe(true);
expect(r.reasons).toEqual([]);
});
test("requireAiApproval blocks when not approved", () => {
const r = evaluateProtection(
rule({ requireAiApproval: true }),
{
aiApproved: false,
humanApprovalCount: 0,
gateResultGreen: true,
hasFailedGates: false,
}
);
expect(r.allowed).toBe(false);
expect(r.reasons[0]).toMatch(/AI approval/i);
});
test("requireAiApproval allows when approved", () => {
const r = evaluateProtection(
rule({ requireAiApproval: true }),
{
aiApproved: true,
humanApprovalCount: 0,
gateResultGreen: true,
hasFailedGates: false,
}
);
expect(r.allowed).toBe(true);
});
test("requireGreenGates blocks when failing", () => {
const r = evaluateProtection(
rule({ requireGreenGates: true }),
{
aiApproved: true,
humanApprovalCount: 1,
gateResultGreen: false,
hasFailedGates: true,
}
);
expect(r.allowed).toBe(false);
expect(r.reasons.some((x) => /green gates/i.test(x))).toBe(true);
});
test("requireHumanReview blocks when 0 approvals", () => {
const r = evaluateProtection(
rule({ requireHumanReview: true }),
{
aiApproved: true,
humanApprovalCount: 0,
gateResultGreen: true,
hasFailedGates: false,
}
);
expect(r.allowed).toBe(false);
expect(r.reasons[0]).toMatch(/human review/i);
});
test("requiredApprovals=2 blocks when only 1", () => {
const r = evaluateProtection(
rule({ requiredApprovals: 2 }),
{
aiApproved: true,
humanApprovalCount: 1,
gateResultGreen: true,
hasFailedGates: false,
}
);
expect(r.allowed).toBe(false);
expect(r.reasons[0]).toMatch(/2 approvals/i);
});
test("requiredApprovals=2 allows when 2 reached", () => {
const r = evaluateProtection(
rule({ requiredApprovals: 2 }),
{
aiApproved: true,
humanApprovalCount: 2,
gateResultGreen: true,
hasFailedGates: false,
}
);
expect(r.allowed).toBe(true);
});
test("multiple rules combine into multiple reasons", () => {
const r = evaluateProtection(
rule({
requireAiApproval: true,
requireGreenGates: true,
requireHumanReview: true,
}),
{
aiApproved: false,
humanApprovalCount: 0,
gateResultGreen: false,
hasFailedGates: true,
}
);
expect(r.allowed).toBe(false);
expect(r.reasons.length).toBeGreaterThanOrEqual(3);
});
});
|