Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesPull RequestsActionsSecurityInsightsSettings
✨ AI
More
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepfix/audit-sweep-2026-07-26gatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
api-auth-2fa.test.ts2.0 KB · 51 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
/**
 * 2FA must hold on the API surface too.
 *
 * `sessions.requires_2fa` is set when the password step succeeds and cleared
 * only once the second factor is accepted (routes/auth.tsx:565, 674, 716).
 * middleware/auth.ts honours it in both its softAuth and requireAuth paths
 * (lines ~200 and ~273).
 *
 * middleware/api-auth.ts's session-cookie fallback checked only expiry. A
 * session that had passed the password step but not 2FA therefore
 * authenticated fully against every route using apiAuth — and was handed
 * ["repo","user","admin"] scopes — bypassing 2FA for the whole API surface.
 */

import { describe, expect, it } from "bun:test";
import { readFileSync } from "fs";

const API_AUTH = readFileSync("src/middleware/api-auth.ts", "utf8");
const AUTH = readFileSync("src/middleware/auth.ts", "utf8");

describe("api-auth session fallback honours requires2fa", () => {
  it("rejects a session still pending its second factor", () => {
    expect(API_AUTH).toContain("!session.requires2fa");
  });

  it("checks it alongside expiry, in the same guard", () => {
    // Guards against the check being added somewhere that a later `return`
    // can skip.
    const guard = API_AUTH.slice(
      API_AUTH.indexOf("// Fall back to session cookie"),
      API_AUTH.indexOf('c.set("authMethod", "session")')
    );
    expect(guard).toContain("expiresAt");
    expect(guard).toContain("!session.requires2fa");
  });

  it("does not grant scopes before the 2FA check", () => {
    const scopeIdx = API_AUTH.indexOf('c.set("tokenScopes", ["repo", "user", "admin"])');
    const checkIdx = API_AUTH.indexOf("!session.requires2fa");
    expect(checkIdx).toBeGreaterThan(-1);
    expect(scopeIdx).toBeGreaterThan(checkIdx);
  });
});

describe("the two middlewares agree", () => {
  it("both consult requires2fa", () => {
    // The bug was a divergence between them; keep them in step.
    expect(AUTH).toContain("session.requires2fa");
    expect(API_AUTH).toContain("session.requires2fa");
  });
});