Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesPull RequestsActionsSecurityInsightsSettings
✨ AI
More
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepfix/audit-sweep-2026-07-26gatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
git-arg-injection.test.ts3.8 KB · 101 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
/**
 * git argument injection.
 *
 * Commands in src/git/repository.ts are arrays run through Bun.spawn, so there
 * is no shell involved and no shell injection. But git parses any leading-dash
 * argument as an option wherever it appears, and several commands take a
 * caller-supplied ref / sha / treeish positionally with no `--` separator.
 *
 * A ref of `--output=/app/src/index.ts` reaching `git log` makes git write its
 * output to that path — unauthenticated arbitrary file write as the app user,
 * reachable through ordinary public-repo URLs like /:owner/:repo/commits/:ref.
 *
 * exec() now refuses option-like arguments centrally. These lock that in and,
 * just as importantly, prove the guard does not reject the flags the module
 * legitimately passes.
 */

import { describe, expect, it } from "bun:test";
import { readFileSync } from "fs";

const SRC = readFileSync("src/git/repository.ts", "utf8");

// Mirror of the module-private predicate, kept in step by the coverage test
// at the bottom which asserts against the real source.
function isAllowedGitFlag(arg: string): boolean {
  const ALLOWED = new Set([
    "--bare", "--format", "--skip", "--verify", "--porcelain", "--max-count",
    "--full-tree", "--quiet", "--stdin", "--short", "--end-of-options", "--",
    "--sort", "--numstat", "--add", "--cacheinfo",
    "-",
    "-a", "-d", "-l", "-r", "-t", "-n", "-I", "-m", "-p", "-s", "-e", "-w", "-1",
  ]);
  if (!arg.startsWith("-")) return true;
  if (/^-\d+$/.test(arg)) return true;
  return ALLOWED.has(arg.split("=", 1)[0]);
}

describe("option-like arguments are refused", () => {
  const attacks = [
    "--output=/app/src/index.ts", // git log: arbitrary file write
    "--output=/tmp/pwned",
    "--upload-pack=/bin/sh",
    "--exec=/bin/sh",
    "-o/tmp/pwned",
    "--git-dir=/etc",
    "--work-tree=/",
  ];
  for (const a of attacks) {
    it(`rejects ${a}`, () => {
      expect(isAllowedGitFlag(a)).toBe(false);
    });
  }

  it("rejects a ref embedded in a rev:path argument", () => {
    // `git show ${ref}:${filePath}` — a dash-leading ref poisons the whole arg.
    expect(isAllowedGitFlag("--output=/tmp/x:README.md")).toBe(false);
  });
});

describe("legitimate arguments still pass", () => {
  const ok = [
    "main", "HEAD", "refs/heads/main", "v1.2.3",
    "abc123def456", "main:src/index.ts", "origin/main..HEAD",
    "--format=%H%x00%s", "--skip=20", "--max-count=50", "--sort=-creatordate",
    "--bare", "--porcelain", "--numstat", "--cacheinfo", "--full-tree", "--",
    "-500", "-30", "-1", "-I", "-w",
    // A branch legitimately containing a dash, just not leading.
    "feature/my-branch", "release-2.0",
  ];
  for (const a of ok) {
    it(`accepts ${a}`, () => {
      expect(isAllowedGitFlag(a)).toBe(true);
    });
  }
});

describe("guard is wired in", () => {
  it("exec() screens every argument after the binary", () => {
    expect(SRC).toContain("refusing option-like argument");
    expect(SRC).toMatch(/for \(let i = 1; i < cmd\.length; i\+\+\)/);
  });

  it("the streaming Bun.spawn paths are guarded too", () => {
    // Two call sites stream instead of buffering and therefore skip exec().
    const guards = SRC.match(/refused option-like git argument/g) ?? [];
    expect(guards.length).toBe(2);
  });

  it("every dash-argument the module actually uses is allowlisted", () => {
    // The real risk of a central guard is breaking legitimate git calls.
    const found = new Set<string>();
    for (const m of SRC.matchAll(/"(-[^"]*)"/g)) found.add(m[1]);
    for (const m of SRC.matchAll(/`(-[^`]*)`/g)) found.add(m[1]);
    const uncovered = [...found].filter((f) => {
      if (f.includes("${")) return false; // template — resolved at runtime
      if (f.startsWith("--output=")) return false; // appears only in a comment
      return !isAllowedGitFlag(f);
    });
    expect(uncovered).toEqual([]);
  });
});