1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
|
import { describe, expect, it } from "bun:test";
import { readFileSync } from "fs";
const SRC = readFileSync("src/git/repository.ts", "utf8");
function isAllowedGitFlag(arg: string): boolean {
const ALLOWED = new Set([
"--bare", "--format", "--skip", "--verify", "--porcelain", "--max-count",
"--full-tree", "--quiet", "--stdin", "--short", "--end-of-options", "--",
"--sort", "--numstat", "--add", "--cacheinfo",
"-",
"-a", "-d", "-l", "-r", "-t", "-n", "-I", "-m", "-p", "-s", "-e", "-w", "-1",
]);
if (!arg.startsWith("-")) return true;
if (/^-\d+$/.test(arg)) return true;
return ALLOWED.has(arg.split("=", 1)[0]);
}
describe("option-like arguments are refused", () => {
const attacks = [
"--output=/app/src/index.ts",
"--output=/tmp/pwned",
"--upload-pack=/bin/sh",
"--exec=/bin/sh",
"-o/tmp/pwned",
"--git-dir=/etc",
"--work-tree=/",
];
for (const a of attacks) {
it(`rejects ${a}`, () => {
expect(isAllowedGitFlag(a)).toBe(false);
});
}
it("rejects a ref embedded in a rev:path argument", () => {
expect(isAllowedGitFlag("--output=/tmp/x:README.md")).toBe(false);
});
});
describe("legitimate arguments still pass", () => {
const ok = [
"main", "HEAD", "refs/heads/main", "v1.2.3",
"abc123def456", "main:src/index.ts", "origin/main..HEAD",
"--format=%H%x00%s", "--skip=20", "--max-count=50", "--sort=-creatordate",
"--bare", "--porcelain", "--numstat", "--cacheinfo", "--full-tree", "--",
"-500", "-30", "-1", "-I", "-w",
"feature/my-branch", "release-2.0",
];
for (const a of ok) {
it(`accepts ${a}`, () => {
expect(isAllowedGitFlag(a)).toBe(true);
});
}
});
describe("guard is wired in", () => {
it("exec() screens every argument after the binary", () => {
expect(SRC).toContain("refusing option-like argument");
expect(SRC).toMatch(/for \(let i = 1; i < cmd\.length; i\+\+\)/);
});
it("the streaming Bun.spawn paths are guarded too", () => {
const guards = SRC.match(/refused option-like git argument/g) ?? [];
expect(guards.length).toBe(2);
});
it("every dash-argument the module actually uses is allowlisted", () => {
const found = new Set<string>();
for (const m of SRC.matchAll(/"(-[^"]*)"/g)) found.add(m[1]);
for (const m of SRC.matchAll(/`(-[^`]*)`/g)) found.add(m[1]);
const uncovered = [...found].filter((f) => {
if (f.includes("${")) return false;
if (f.startsWith("--output=")) return false;
return !isAllowedGitFlag(f);
});
expect(uncovered).toEqual([]);
});
});
|