Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesPull RequestsActionsSecurityInsightsSettings
✨ AI
More
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepfix/audit-sweep-2026-07-26gatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
saml-signature.test.ts3.3 KB · 82 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
/**
 * SAML assertion verification.
 *
 * Two defects, both allowing account takeover:
 *
 *  1. Fail-open. Signature verification ran only `if (idpCertPem && trim())`,
 *     so an org whose SAML config had a blank idp_certificate accepted ANY
 *     forged SAMLResponse. The assertion's email selects the account to log
 *     in as, so that is unauthenticated takeover of any account in the org.
 *
 *  2. Signature wrapping. verifySamlSignature checks only that SignedInfo
 *     carries a valid RSA signature; the Reference DigestValue is never
 *     recomputed. A genuinely-signed assertion could be edited — or a second
 *     forged Assertion added beside the signed one — and still verify.
 *
 * Full XML-DSig needs exclusive c14n and a vetted library. These lock in the
 * fail-closed behaviour and the structural anti-wrapping checks that stand in
 * until then.
 */

import { describe, expect, it } from "bun:test";
import { readFileSync } from "fs";

const SRC = readFileSync("src/routes/saml-sso.tsx", "utf8");

describe("verification is mandatory (fail-closed)", () => {
  it("refuses when no IdP certificate is configured", () => {
    expect(SRC).toContain("if (!idpCertPem || !idpCertPem.trim())");
    expect(SRC).toContain("Refusing to accept an unverified assertion");
  });

  it("no longer makes verification conditional on the cert being present", () => {
    // The original bug shape.
    expect(SRC).not.toMatch(/if \(idpCertPem && idpCertPem\.trim\(\)\) \{\s*\n\s*const sigValid/);
  });
});

describe("anti-wrapping structural checks", () => {
  it("runs before signature verification", () => {
    const coverage = SRC.indexOf("assertSignatureCoversAssertion(xml)");
    const verify = SRC.indexOf("if (!verifySamlSignature(xml, idpCertPem))");
    expect(coverage).toBeGreaterThan(-1);
    expect(verify).toBeGreaterThan(-1);
    // A rewritten-but-validly-signed document must not reach attribute
    // extraction just because SignedInfo checks out.
    expect(coverage).toBeLessThan(verify);
  });

  it("rejects multiple Assertions", () => {
    expect(SRC).toContain("assertionIds.length > 1");
    expect(SRC).toContain("signature-wrapping attempt");
  });

  it("rejects a Reference that covers neither the Response nor the Assertion", () => {
    expect(SRC).toContain("referenced !== assertionIds[0] && referenced !== responseId");
  });

  it("rejects a response with no Assertion at all", () => {
    expect(SRC).toContain("assertionIds.length === 0");
  });
});

describe("signature algorithm selection", () => {
  it("reads Algorithm from SignatureMethod, not the first match in the doc", () => {
    // The old regex /Algorithm="([^"]+)"/ matched CanonicalizationMethod,
    // which appears first in a normal response — so the real algorithm was
    // never read and it silently fell back to SHA1.
    expect(SRC).toContain("SignatureMethod[^>]*\\bAlgorithm=");
    expect(SRC).not.toMatch(/const algMatch = xml\.match\(\/Algorithm=/);
  });

  it("refuses an unrecognised algorithm instead of defaulting to SHA1", () => {
    expect(SRC).toContain("unrecognised SignatureMethod");
  });
});

describe("the incompleteness is documented, not hidden", () => {
  it("verifySamlSignature is marked as not proving assertion integrity", () => {
    // Whoever reads this next must not mistake it for full XML-DSig.
    expect(SRC).toContain("INCOMPLETE BY DESIGN");
  });
});