1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
|
import { describe, it, expect } from "bun:test";
import app from "../app";
import {
REVIEW_SOURCES,
REVIEW_STATES,
isValidSource,
isValidState,
nextState,
__internal,
} from "../lib/review-requests";
describe("review-requests — isValidSource", () => {
it("accepts the three canonical sources", () => {
for (const s of REVIEW_SOURCES) expect(isValidSource(s)).toBe(true);
});
it("rejects unknown sources", () => {
expect(isValidSource("auto")).toBe(false);
expect(isValidSource("")).toBe(false);
expect(isValidSource("CODEOWNERS")).toBe(false);
});
});
describe("review-requests — isValidState", () => {
it("accepts the four canonical states", () => {
for (const s of REVIEW_STATES) expect(isValidState(s)).toBe(true);
});
it("rejects unknown states", () => {
expect(isValidState("open")).toBe(false);
expect(isValidState("approved!")).toBe(false);
expect(isValidState("")).toBe(false);
});
});
describe("review-requests — nextState", () => {
it("dismissed is terminal — nothing moves it", () => {
expect(nextState("dismissed", "approved")).toBe("dismissed");
expect(nextState("dismissed", "changes_requested")).toBe("dismissed");
expect(nextState("dismissed", "commented")).toBe("dismissed");
expect(nextState("dismissed", "dismissed")).toBe("dismissed");
});
it("commented leaves state unchanged", () => {
expect(nextState("pending", "commented")).toBe("pending");
expect(nextState("approved", "commented")).toBe("approved");
expect(nextState("changes_requested", "commented")).toBe("changes_requested");
});
it("approved / changes_requested overwrite pending + each other", () => {
expect(nextState("pending", "approved")).toBe("approved");
expect(nextState("pending", "changes_requested")).toBe("changes_requested");
expect(nextState("approved", "changes_requested")).toBe("changes_requested");
expect(nextState("changes_requested", "approved")).toBe("approved");
});
it("dismissed outcome transitions non-dismissed to dismissed", () => {
expect(nextState("pending", "dismissed")).toBe("dismissed");
expect(nextState("approved", "dismissed")).toBe("dismissed");
expect(nextState("changes_requested", "dismissed")).toBe("dismissed");
});
});
describe("review-requests — sanitiseCandidates", () => {
const { sanitiseCandidates } = __internal;
it("drops nulls, undefineds, and empty strings", () => {
expect(sanitiseCandidates([null, undefined, "", "u1"], null)).toEqual([
"u1",
]);
});
it("de-dupes preserving first-seen order", () => {
expect(sanitiseCandidates(["u1", "u2", "u1", "u3", "u2"], null)).toEqual([
"u1",
"u2",
"u3",
]);
});
it("excludes the PR author from the result", () => {
expect(
sanitiseCandidates(["author", "u1", "author", "u2"], "author")
).toEqual(["u1", "u2"]);
});
it("handles no-author case", () => {
expect(sanitiseCandidates(["u1"], null)).toEqual(["u1"]);
expect(sanitiseCandidates(["u1"], undefined)).toEqual(["u1"]);
});
it("returns [] for all-invalid input", () => {
expect(sanitiseCandidates([null, undefined, ""], null)).toEqual([]);
});
it("preserves the author if explicitly included with a different-string ID", () => {
expect(sanitiseCandidates(["author-x"], "author")).toEqual(["author-x"]);
});
});
describe("review-requests — routes", () => {
it("POST /:o/:r/pulls/:n/reviewers requires auth (redirects unauthed)", async () => {
const res = await app.request(
"/alice/nope/pulls/1/reviewers",
{ method: "POST", body: "username=bob" }
);
expect([302, 401].includes(res.status)).toBe(true);
});
it("POST dismiss route requires auth", async () => {
const res = await app.request(
"/alice/nope/pulls/1/reviewers/x/dismiss",
{ method: "POST" }
);
expect([302, 401].includes(res.status)).toBe(true);
});
it("POST with invalid bearer token → 401 JSON", async () => {
const res = await app.request(
"/alice/nope/pulls/1/reviewers",
{
method: "POST",
headers: { authorization: "Bearer glc_garbage" },
body: "username=bob",
}
);
expect(res.status).toBe(401);
});
});
|