CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 | /**
* Reliable webhook delivery — retry queue + dead-letter coverage.
*
* Pins down `src/lib/webhook-delivery.ts`:
* - 2xx response on the first attempt → status='succeeded' + succeeded_at
* - 5xx response → row stays 'pending', attempt_count increments,
* next_attempt_at lands ~30s out (first backoff step)
* - After MAX_ATTEMPTS-1 consecutive failures the next attempt flips the
* row to status='dead' (no further retries)
*
* Strategy: each test spins up a tiny Bun.serve() on a random port and points
* a freshly-created `webhooks` row at it, then drives `attemptDelivery()`
* directly so we don't depend on worker timing.
*
* DB-backed only — gated on `DATABASE_URL` to keep CI green without
* Postgres, matching the `HAS_DB` skipIf pattern used elsewhere.
*/
import { describe, it, expect } from "bun:test";
const HAS_DB = Boolean(process.env.DATABASE_URL);
// ---------------------------------------------------------------------------
// Pure logic — backoff table shape (runs without a DB).
// ---------------------------------------------------------------------------
describe("webhook-delivery — backoff schedule", () => {
it("defines MAX_ATTEMPTS=6 and monotonically increasing backoffs", async () => {
const { MAX_ATTEMPTS, BACKOFF_MS } = await import(
"../lib/webhook-delivery"
);
expect(MAX_ATTEMPTS).toBe(6);
// Indices 1..5 hold the schedule (slot 0 is the unused immediate slot).
expect(BACKOFF_MS[1]).toBe(30_000);
expect(BACKOFF_MS[2]).toBe(120_000);
expect(BACKOFF_MS[3]).toBe(600_000);
expect(BACKOFF_MS[4]).toBe(3_600_000);
expect(BACKOFF_MS[5]).toBe(21_600_000);
for (let i = 2; i < BACKOFF_MS.length; i++) {
expect(BACKOFF_MS[i]).toBeGreaterThan(BACKOFF_MS[i - 1]!);
}
});
});
// ---------------------------------------------------------------------------
// DB-backed end-to-end: spins up a tiny target server per case.
// ---------------------------------------------------------------------------
interface Fixture {
userId: string;
repoId: string;
webhookId: string;
cleanup: () => Promise<void>;
}
async function makeFixture(targetUrl: string): Promise<Fixture> {
const { db } = await import("../db");
const { users, repositories, webhooks } = await import("../db/schema");
const { eq } = await import("drizzle-orm");
const uname = "whd-" + Math.random().toString(36).slice(2, 10);
const [user] = await db
.insert(users)
.values({
username: uname,
email: `${uname}@example.com`,
passwordHash: "x",
})
.returning();
const [repo] = await db
.insert(repositories)
.values({
name: "whd-repo-" + Math.random().toString(36).slice(2, 8),
ownerId: user.id,
diskPath: `/tmp/whd-${user.id}`,
})
.returning();
const [hook] = await db
.insert(webhooks)
.values({
repositoryId: repo.id,
url: targetUrl,
secret: "test-secret",
events: "push",
isActive: true,
})
.returning();
return {
userId: user.id,
repoId: repo.id,
webhookId: hook.id,
cleanup: async () => {
// Cascade: deleting the user wipes the repo (FK) which wipes the
// hook (FK) which wipes the deliveries (FK).
try {
await db.delete(users).where(eq(users.id, user.id));
} catch {
/* swallow */
}
},
};
}
describe("webhook-delivery — successful first attempt", () => {
it.skipIf(!HAS_DB)("2xx → status='succeeded' + succeeded_at set", async () => {
const server = Bun.serve({
port: 0,
fetch: () => new Response("ok", { status: 200 }),
});
const url = `http://localhost:${server.port}/hook`;
const fx = await makeFixture(url);
try {
const { db } = await import("../db");
const { webhookDeliveries } = await import("../db/schema");
const { eq } = await import("drizzle-orm");
const { enqueueWebhookDelivery, attemptDelivery } = await import(
"../lib/webhook-delivery"
);
const id = await enqueueWebhookDelivery({
webhookId: fx.webhookId,
secret: "test-secret",
event: "push",
payload: { hello: "world" },
});
expect(id).toBeTruthy();
const result = await attemptDelivery(id!);
expect(result).toBe("succeeded");
const [row] = await db
.select()
.from(webhookDeliveries)
.where(eq(webhookDeliveries.id, id!));
expect(row.status).toBe("succeeded");
expect(row.attemptCount).toBe(1);
expect(row.lastStatusCode).toBe(200);
expect(row.succeededAt).toBeTruthy();
expect(row.nextAttemptAt).toBeNull();
expect(row.lastError).toBeNull();
} finally {
await fx.cleanup();
server.stop(true);
}
});
});
describe("webhook-delivery — retry on 5xx", () => {
it.skipIf(!HAS_DB)(
"500 → status stays 'pending', attempt_count=1, next_attempt_at ~30s out",
async () => {
const server = Bun.serve({
port: 0,
fetch: () => new Response("boom", { status: 500 }),
});
const url = `http://localhost:${server.port}/hook`;
const fx = await makeFixture(url);
try {
const { db } = await import("../db");
const { webhookDeliveries } = await import("../db/schema");
const { eq } = await import("drizzle-orm");
const { enqueueWebhookDelivery, attemptDelivery, BACKOFF_MS } =
await import("../lib/webhook-delivery");
const id = await enqueueWebhookDelivery({
webhookId: fx.webhookId,
secret: "test-secret",
event: "push",
payload: { fail: true },
});
expect(id).toBeTruthy();
const before = Date.now();
const result = await attemptDelivery(id!);
expect(result).toBe("retry");
const [row] = await db
.select()
.from(webhookDeliveries)
.where(eq(webhookDeliveries.id, id!));
expect(row.status).toBe("pending");
expect(row.attemptCount).toBe(1);
expect(row.lastStatusCode).toBe(500);
expect(row.lastError).toContain("500");
expect(row.succeededAt).toBeNull();
// next_attempt_at should land in the future, roughly at +BACKOFF_MS[1]
// (allow generous slack for slow test runners + DB rounding).
expect(row.nextAttemptAt).toBeTruthy();
const nextMs = new Date(row.nextAttemptAt!).getTime();
const expected = before + BACKOFF_MS[1]!;
expect(nextMs).toBeGreaterThanOrEqual(expected - 5_000);
expect(nextMs).toBeLessThanOrEqual(expected + 60_000);
} finally {
await fx.cleanup();
server.stop(true);
}
}
);
});
describe("webhook-delivery — dead-letter after max attempts", () => {
it.skipIf(!HAS_DB)(
"after MAX_ATTEMPTS consecutive failures → status='dead'",
async () => {
const server = Bun.serve({
port: 0,
fetch: () => new Response("nope", { status: 503 }),
});
const url = `http://localhost:${server.port}/hook`;
const fx = await makeFixture(url);
try {
const { db } = await import("../db");
const { webhookDeliveries } = await import("../db/schema");
const { eq } = await import("drizzle-orm");
const { enqueueWebhookDelivery, attemptDelivery, MAX_ATTEMPTS } =
await import("../lib/webhook-delivery");
const id = await enqueueWebhookDelivery({
webhookId: fx.webhookId,
secret: "test-secret",
event: "push",
payload: { will: "die" },
});
expect(id).toBeTruthy();
// Drive every attempt back-to-back. We bypass the wall-clock backoff
// by calling attemptDelivery() directly — the schedule check lives
// in the *worker*, not in the per-attempt path.
let last: string = "";
for (let i = 0; i < MAX_ATTEMPTS; i++) {
last = await attemptDelivery(id!);
}
expect(last).toBe("dead");
const [row] = await db
.select()
.from(webhookDeliveries)
.where(eq(webhookDeliveries.id, id!));
expect(row.status).toBe("dead");
expect(row.attemptCount).toBe(MAX_ATTEMPTS);
expect(row.lastStatusCode).toBe(503);
expect(row.nextAttemptAt).toBeNull();
expect(row.succeededAt).toBeNull();
// Owner alert — previously the only signal on a permanently-dead
// delivery was a console.error nobody reads. notifyWebhookDead()
// is fire-and-forget (not awaited by attemptDelivery), so poll
// briefly rather than assume it landed synchronously.
const { notifications } = await import("../db/schema");
let notif: { kind: string; repositoryId: string | null } | undefined;
for (let i = 0; i < 20 && !notif; i++) {
const rows = await db
.select({ kind: notifications.kind, repositoryId: notifications.repositoryId })
.from(notifications)
.where(eq(notifications.userId, fx.userId));
notif = rows.find((r) => r.kind === "integration_dead");
if (!notif) await new Promise((res) => setTimeout(res, 50));
}
expect(notif).toBeDefined();
expect(notif!.repositoryId).toBe(fx.repoId);
} finally {
await fx.cleanup();
server.stop(true);
}
}
);
});
|