Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesPull RequestsActionsSecurityInsightsSettings
✨ AI
More
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepfix/audit-sweep-2026-07-26gatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
api-v2-repo-privacy.test.ts3.4 KB · 80 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
/**
 * Private repositories must not be readable through the v2 REST API.
 *
 * Regression test for a live data leak found 2026-07-27: five git-content
 * endpoints under /api/v2/repos/:owner/:repo gated only on `repoExists()`,
 * which is a bare filesystem probe (Bun.file(<repoPath>/HEAD).exists()) and
 * never reads the repositories row — so it never sees isPrivate. Anonymous
 * callers could read branches, commit history (with author emails), the full
 * recursive tree, and raw file contents of any private repo, while the HTML
 * surface correctly returned 404.
 *
 * These are structural assertions rather than live HTTP calls: the leak was a
 * missing gate, and what must not regress is that the gate exists and is
 * mounted at the router rather than sprinkled per-handler.
 */

import { describe, expect, it } from "bun:test";
import { readFileSync } from "fs";

const SRC = readFileSync("src/routes/api-v2.ts", "utf8");

describe("api-v2 repo privacy gate", () => {
  it("is mounted on the whole /repos/:owner/:repo subtree", () => {
    expect(SRC).toContain('apiv2.use("/repos/:owner/:repo", repoPrivacyGate)');
    expect(SRC).toContain('apiv2.use("/repos/:owner/:repo/*", repoPrivacyGate)');
  });

  it("denies with 404, never 403 — a private repo must not confirm it exists", () => {
    const gate = SRC.slice(
      SRC.indexOf("async function repoPrivacyGate"),
      SRC.indexOf("// ─── Helper")
    );
    expect(gate).toContain('access === "none"');
    expect(gate).toContain('c.json({ error: "Not found" }, 404)');
    // No 403 as an actual returned status (the word appears in a comment
    // explaining why 404 is the right choice, hence matching the call shape).
    expect(gate).not.toMatch(/,\s*403\s*\)/);
  });

  it("uses resolveRepoAccess, not an ownerId comparison", () => {
    const gate = SRC.slice(
      SRC.indexOf("async function repoPrivacyGate"),
      SRC.indexOf("// ─── Helper")
    );
    // An ownerId equality check would wrongly deny collaborators and org
    // members — that was the flaw in the pre-existing inline checks.
    expect(gate).toContain("resolveRepoAccess");
    expect(gate).not.toMatch(/user\.id\s*!==\s*\w*[Oo]wner/);
  });

  it("runs after apiAuth so the viewer identity is populated", () => {
    // If the gate were registered before apiAuth, c.get("user") would always
    // be undefined and every private repo would 404 even for its owner.
    expect(SRC.indexOf('apiv2.use("*", apiAuth)')).toBeLessThan(
      SRC.indexOf('apiv2.use("/repos/:owner/:repo", repoPrivacyGate)')
    );
  });

  it("lets unknown repos fall through to each handler's own 404", () => {
    const gate = SRC.slice(
      SRC.indexOf("async function repoPrivacyGate"),
      SRC.indexOf("// ─── Helper")
    );
    expect(gate).toContain("if (!resolved) return next()");
  });
});

describe("repoExists is not a privacy check", () => {
  it("never consults the repositories table", () => {
    const repo = readFileSync("src/git/repository.ts", "utf8");
    const fn = repo.slice(
      repo.indexOf("export async function repoExists"),
      repo.indexOf("export async function repoExists") + 400
    );
    // Documents WHY the router gate is required: this helper cannot answer
    // "may this caller see it?", only "is there a directory on disk?".
    expect(fn).not.toContain("isPrivate");
    expect(fn).not.toContain("repositories");
  });
});