feat(gate): send baseSha to GateTest so enforcement scopes to the change #5622
ccantynzAI Reviewcommented 20h ago
AI Triage
(no summary)
Priority: medium Risk area: mixed
Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)
Suggestions only — nothing has been applied. The PR author stays in control.
gluecron[bot]🤖 botAI Reviewcommented 20h ago
AI review unavailable
The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Summary
notifyGateTestOfPushnow forwards post-receive'soldShaasbaseSha(omitted on branch creation / all-zeros → GateTest honestly reports "base unknown").runAllGateChecksresolves the merge-base of base and head (base tip would misattribute base-side changes to the PR) and passes it to the blockingrunGateTestScan; any resolution failure degrades to the previous whole-repo behavior.baseShais the pinned contract with the GateTest side (maps intoscan_queue.base_sha).Also audited (no code change needed): nothing in gate_runs consumers or notifications treats
passed+ non-zero issue count as impossible —statusis authoritative,detailsis opaque JSON.Test plan
src/__tests__/gatetest-base-sha.test.ts— baseSha included for real SHAs, omitted for all-zeros and unknown, both async and blocking payloads (5 pass)bun buildclean