CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 | /**
* E2E — Pull request flows
*
* Covers: create PR, add comment, merge PR, close PR.
*
* Strategy: beforeAll pushes an initial commit to main, then pushes a
* feature branch. We create a PR from the feature branch against main
* and exercise the PR lifecycle within a single spec run.
*/
import { test, expect } from "@playwright/test";
import * as path from "path";
import * as fs from "fs/promises";
import {
uid,
TEST_PASSWORD,
pushTestCommit,
pushFeatureBranch,
cleanupDir,
} from "./fixtures";
// ---------------------------------------------------------------------------
// Shared state
// ---------------------------------------------------------------------------
let owner: string;
let repoName: string;
let featureBranch: string;
let tmpDir: string;
test.beforeAll(async ({ browser }) => {
owner = uid("pruser");
repoName = uid("prerepo");
featureBranch = uid("feat-");
const page = await browser.newPage();
// Register
await page.goto("/register");
await page.fill('input[name="username"]', owner);
await page.fill('input[name="email"]', `${owner}@test.example`);
await page.fill('input[name="password"]', TEST_PASSWORD);
await page.click('button[type="submit"]');
await page.waitForURL(/\/(dashboard|[a-z])/);
// Create repo
await page.goto("/new");
await page.fill('input[name="name"]', repoName);
await page.click('button[type="submit"]');
await page.waitForURL(new RegExp(`/${owner}/${repoName}`));
await page.close();
// Push initial commit to main
tmpDir = await pushTestCommit({
owner,
repo: repoName,
username: owner,
password: TEST_PASSWORD,
fileName: "README.md",
fileContent: `# ${repoName}\n`,
commitMsg: "Initial commit",
});
// Push feature branch
featureBranch = await pushFeatureBranch({
repoDir: tmpDir,
username: owner,
branchName: featureBranch,
fileName: "feature.md",
fileContent: "Feature branch content.\n",
commitMsg: "Add feature file",
});
});
test.afterAll(async () => {
await cleanupDir(tmpDir);
});
// ---------------------------------------------------------------------------
// Helper: log in the page as owner
// ---------------------------------------------------------------------------
async function loginAsOwner(page: Parameters<typeof test>[1] extends never ? never : any): Promise<void> {
await page.goto("/login");
await page.fill('input[name="username"]', owner);
await page.fill('input[name="password"]', TEST_PASSWORD);
await page.click('button[type="submit"]');
await page.waitForURL(/\/(dashboard|[a-z])/);
}
// ---------------------------------------------------------------------------
// Create PR
// ---------------------------------------------------------------------------
test.describe("Pull request creation", () => {
test("PR list page is accessible", async ({ page }) => {
await page.goto(`/${owner}/${repoName}/pulls`);
await expect(page).toHaveURL(new RegExp(`/${owner}/${repoName}/pulls`));
// Even if empty, the page should render without error
await expect(page.locator("body")).not.toContainText(/500|Internal Server Error/i);
});
test("can open a new PR from the compare page", async ({ page }) => {
await loginAsOwner(page);
// Navigate to compare page with the feature branch
await page.goto(`/${owner}/${repoName}/compare/main...${featureBranch}`);
// Should show a PR creation form
const titleInput = page.locator('input[name="title"]');
await expect(titleInput).toBeVisible({ timeout: 8_000 });
// Fill in PR details
const prTitle = `E2E PR ${uid("pr")}`;
await titleInput.fill(prTitle);
await page.click('button[type="submit"]');
// Should redirect to the new PR
await expect(page).toHaveURL(new RegExp(`/${owner}/${repoName}/pulls/\\d+`));
await expect(page.locator("body")).toContainText(prTitle);
});
});
// ---------------------------------------------------------------------------
// PR comment
// ---------------------------------------------------------------------------
test.describe("Pull request comment", () => {
let prUrl: string;
test.beforeAll(async ({ browser }) => {
// Create a PR programmatically so we have a URL to comment on
const page = await browser.newPage();
await loginAsOwner(page);
await page.goto(`/${owner}/${repoName}/compare/main...${featureBranch}`);
const titleInput = page.locator('input[name="title"]');
await titleInput.waitFor({ timeout: 8_000 });
await titleInput.fill(`Comment-test PR ${uid("c")}`);
await page.click('button[type="submit"]');
await page.waitForURL(new RegExp(`/${owner}/${repoName}/pulls/\\d+`));
prUrl = page.url();
await page.close();
});
test("can post a comment on a PR", async ({ page }) => {
await loginAsOwner(page);
await page.goto(prUrl);
const commentBox = page.locator(
'textarea[name="body"], textarea[name="comment"]'
).first();
await expect(commentBox).toBeVisible({ timeout: 8_000 });
const commentText = `Test comment ${uid("cmt")}`;
await commentBox.fill(commentText);
await page.click('button[type="submit"]');
await expect(page.locator("body")).toContainText(commentText, {
timeout: 8_000,
});
});
});
// ---------------------------------------------------------------------------
// Merge PR
// ---------------------------------------------------------------------------
test.describe("Pull request merge", () => {
let prUrl: string;
test.beforeAll(async ({ browser }) => {
const page = await browser.newPage();
await loginAsOwner(page);
await page.goto(`/${owner}/${repoName}/compare/main...${featureBranch}`);
const titleInput = page.locator('input[name="title"]');
await titleInput.waitFor({ timeout: 8_000 });
await titleInput.fill(`Merge-test PR ${uid("m")}`);
await page.click('button[type="submit"]');
await page.waitForURL(new RegExp(`/${owner}/${repoName}/pulls/\\d+`));
prUrl = page.url();
await page.close();
});
test("merge button is visible on an open PR", async ({ page }) => {
await loginAsOwner(page);
await page.goto(prUrl);
// The merge button may be disabled if checks are pending — just check visible
const mergeBtn = page.locator(
'button:has-text("Merge"), button[name="action"][value="merge"], form[action*="merge"] button'
).first();
await expect(mergeBtn).toBeVisible({ timeout: 8_000 });
});
test("can merge an open PR", async ({ page }) => {
await loginAsOwner(page);
await page.goto(prUrl);
const mergeBtn = page.locator(
'button:has-text("Merge"), button[name="action"][value="merge"], form[action*="merge"] button'
).first();
// Only click if enabled — if branch-protection blocks it, skip gracefully
if (await mergeBtn.isEnabled()) {
await mergeBtn.click();
await expect(page.locator("body")).toContainText(/merged/i, {
timeout: 10_000,
});
} else {
test.skip();
}
});
});
// ---------------------------------------------------------------------------
// Close PR
// ---------------------------------------------------------------------------
test.describe("Pull request close", () => {
let prUrl: string;
test.beforeAll(async ({ browser }) => {
// Push another unique branch so we have an un-merged PR to close
const closeBranch = uid("close-");
await pushFeatureBranch({
repoDir: tmpDir,
username: owner,
branchName: closeBranch,
fileName: `close-${uid()}.md`,
fileContent: "Close branch file.\n",
commitMsg: "Add close-branch file",
});
const page = await browser.newPage();
await loginAsOwner(page);
await page.goto(`/${owner}/${repoName}/compare/main...${closeBranch}`);
const titleInput = page.locator('input[name="title"]');
await titleInput.waitFor({ timeout: 8_000 });
await titleInput.fill(`Close-test PR ${uid("cl")}`);
await page.click('button[type="submit"]');
await page.waitForURL(new RegExp(`/${owner}/${repoName}/pulls/\\d+`));
prUrl = page.url();
await page.close();
});
test("can close an open PR", async ({ page }) => {
await loginAsOwner(page);
await page.goto(prUrl);
// Close button — server may render it as a form submit or link
const closeBtn = page.locator(
'button:has-text("Close"), button[value="close"], form[action*="close"] button'
).first();
await expect(closeBtn).toBeVisible({ timeout: 8_000 });
await closeBtn.click();
await expect(page.locator("body")).toContainText(/closed/i, {
timeout: 8_000,
});
});
});
// ---------------------------------------------------------------------------
// PR command center — /pulls smoke test
// ---------------------------------------------------------------------------
test.describe("PR command center (/pulls)", () => {
test("page loads without 500 when unauthenticated", async ({ page }) => {
const res = await page.goto("/pulls");
// Unauthenticated users get redirected to login — either way, no 500
expect(res?.status()).not.toBe(500);
await expect(page.locator("body")).not.toContainText(/500|Internal Server Error/i);
});
test("page loads without 500 when authenticated", async ({ page }) => {
const user = uid("pdash");
await page.goto("/register");
await page.fill('input[name="username"]', user);
await page.fill('input[name="email"]', `${user}@test.example`);
await page.fill('input[name="password"]', TEST_PASSWORD);
await page.click('button[type="submit"]');
await page.waitForURL(/\/(dashboard|[a-z])/);
const res = await page.goto("/pulls");
expect(res?.status()).not.toBe(500);
await expect(page.locator("body")).not.toContainText(/500|Internal Server Error/i);
});
});
// ---------------------------------------------------------------------------
// Regression: PR detail must not 500 when git repo dir is missing
// (Fixes: 500 on McCracken/Gluecron.com #1 — bare repo missing from FS)
// ---------------------------------------------------------------------------
test.describe("PR detail — missing git repo (regression)", () => {
let prUrl: string;
let ghostOwner: string;
let ghostRepo: string;
let gitRepoPath: string;
let backupPath: string;
let ghostTmpDir: string;
test.beforeAll(async ({ browser }) => {
ghostOwner = uid("ghostuser");
ghostRepo = uid("ghostrepo");
const branch = uid("ghost-feat-");
const page = await browser.newPage();
// Register
await page.goto("/register");
await page.fill('input[name="username"]', ghostOwner);
await page.fill('input[name="email"]', `${ghostOwner}@test.example`);
await page.fill('input[name="password"]', TEST_PASSWORD);
await page.click('button[type="submit"]');
await page.waitForURL(/\/(dashboard|[a-z])/);
// Create repo
await page.goto("/new");
await page.fill('input[name="name"]', ghostRepo);
await page.click('button[type="submit"]');
await page.waitForURL(new RegExp(`/${ghostOwner}/${ghostRepo}`));
await page.close();
// Push initial commit + feature branch
ghostTmpDir = await pushTestCommit({
owner: ghostOwner,
repo: ghostRepo,
username: ghostOwner,
password: TEST_PASSWORD,
fileName: "README.md",
fileContent: `# ${ghostRepo}\n`,
commitMsg: "Initial commit",
});
await pushFeatureBranch({
repoDir: ghostTmpDir,
username: ghostOwner,
branchName: branch,
fileName: "ghost.md",
fileContent: "Ghost feature.\n",
commitMsg: "Add ghost feature",
});
// Create the PR via UI
const prPage = await browser.newPage();
await prPage.goto("/login");
await prPage.fill('input[name="username"]', ghostOwner);
await prPage.fill('input[name="password"]', TEST_PASSWORD);
await prPage.click('button[type="submit"]');
await prPage.waitForURL(/\/(dashboard|[a-z])/);
await prPage.goto(`/${ghostOwner}/${ghostRepo}/compare/main...${branch}`);
const titleInput = prPage.locator('input[name="title"]');
await titleInput.waitFor({ timeout: 8_000 });
await titleInput.fill(`Ghost PR ${uid("gp")}`);
await prPage.click('button[type="submit"]');
await prPage.waitForURL(new RegExp(`/${ghostOwner}/${ghostRepo}/pulls/\\d+`));
prUrl = prPage.url();
await prPage.close();
// Simulate missing git repo directory — rename it out of the way
const reposRoot =
process.env.GIT_REPOS_PATH ?? path.join(process.cwd(), "repos");
gitRepoPath = path.join(reposRoot, ghostOwner, `${ghostRepo}.git`);
backupPath = `${gitRepoPath}.missing`;
await fs.rename(gitRepoPath, backupPath).catch(() => {
// If rename fails (e.g. repo dir doesn't exist for some reason), continue
});
});
test.afterAll(async () => {
// Restore the git repo directory so the test environment stays clean
if (backupPath && gitRepoPath) {
await fs.rename(backupPath, gitRepoPath).catch(() => {});
}
await cleanupDir(ghostTmpDir);
});
test("PR detail renders without 500 when git repo is missing from disk", async ({
page,
}) => {
const res = await page.goto(prUrl);
// Must not be a 500
expect(res?.status()).not.toBe(500);
await expect(page.locator("body")).not.toContainText(
/500|Internal Server Error/i
);
// PR data from DB should still be visible (title / state)
await expect(page.locator("body")).toContainText(/open|ghost/i, {
timeout: 8_000,
});
});
});
|