Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepgatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
review-requests.ts8.6 KB · 295 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
/**
 * Block J11 — PR review requests (auto-assign + manual).
 *
 * Manages the set of users who have been asked to review a pull request.
 * Rows are idempotent per (pr, reviewer) — calling `requestReviewers` twice
 * with the same reviewer is a no-op. Sources:
 *   - 'codeowners' — auto-assigned from the repo's CODEOWNERS rules on PR open
 *   - 'manual'     — a maintainer added the reviewer by hand
 *   - 'ai'         — PR triage suggested them
 *
 * State transitions:
 *   pending → approved | changes_requested | dismissed
 *
 * All DB helpers swallow errors and return safe defaults — never throw — so
 * review-request failures can never block PR creation or merge flows.
 */

import { and, eq, inArray, sql } from "drizzle-orm";
import { db } from "../db";
import { prReviewRequests, users } from "../db/schema";
import { reviewersForChangedFiles } from "./codeowners";
import { notify } from "./notify";

export type ReviewSource = "codeowners" | "manual" | "ai";
export type ReviewState =
  | "pending"
  | "approved"
  | "changes_requested"
  | "dismissed";

export const REVIEW_SOURCES: ReviewSource[] = ["codeowners", "manual", "ai"];
export const REVIEW_STATES: ReviewState[] = [
  "pending",
  "approved",
  "changes_requested",
  "dismissed",
];

export function isValidSource(s: string): s is ReviewSource {
  return (REVIEW_SOURCES as string[]).includes(s);
}

export function isValidState(s: string): s is ReviewState {
  return (REVIEW_STATES as string[]).includes(s);
}

/**
 * Deterministic merger: given an existing request state and a fresh review
 * outcome, return what the new state should be. Dismissed is terminal unless
 * someone explicitly re-requests.
 */
export function nextState(
  prev: ReviewState,
  incoming: "approved" | "changes_requested" | "commented" | "dismissed"
): ReviewState {
  if (prev === "dismissed") return "dismissed";
  if (incoming === "commented") return prev; // comment doesn't resolve the request
  return incoming;
}

/**
 * Filter helper — remove author + duplicates + empties from a candidate
 * reviewer ID set. Pure; safe with null/undefined inputs.
 */
export function sanitiseCandidates(
  candidateIds: Array<string | null | undefined>,
  authorId: string | null | undefined
): string[] {
  const seen = new Set<string>();
  const out: string[] = [];
  for (const id of candidateIds) {
    if (!id) continue;
    if (id === authorId) continue;
    if (seen.has(id)) continue;
    seen.add(id);
    out.push(id);
  }
  return out;
}

/**
 * Request reviews from a set of users. Idempotent — existing (pr, reviewer)
 * rows are left alone (we preserve their state, which may be non-pending
 * from a prior review cycle). Returns the list of reviewer IDs that were
 * newly inserted.
 */
export async function requestReviewers(
  pullRequestId: string,
  reviewerIds: string[],
  requestedBy: string | null,
  source: ReviewSource
): Promise<string[]> {
  const cleaned = sanitiseCandidates(reviewerIds, null);
  if (cleaned.length === 0) return [];
  try {
    const existing = await db
      .select({ reviewerId: prReviewRequests.reviewerId })
      .from(prReviewRequests)
      .where(
        and(
          eq(prReviewRequests.pullRequestId, pullRequestId),
          inArray(prReviewRequests.reviewerId, cleaned)
        )
      );
    const have = new Set(existing.map((r) => r.reviewerId));
    const fresh = cleaned.filter((id) => !have.has(id));
    if (fresh.length === 0) return [];
    await db.insert(prReviewRequests).values(
      fresh.map((reviewerId) => ({
        pullRequestId,
        reviewerId,
        requestedBy,
        source,
        state: "pending" as const,
      }))
    );
    return fresh;
  } catch (err) {
    console.error("[review-requests] requestReviewers failed:", err);
    return [];
  }
}

/** List all requested reviewers for a PR with username joined. */
export async function listForPr(
  pullRequestId: string
): Promise<
  Array<{
    id: string;
    reviewerId: string;
    username: string;
    source: ReviewSource;
    state: ReviewState;
    requestedAt: Date;
    resolvedAt: Date | null;
  }>
> {
  try {
    const rows = await db
      .select({
        id: prReviewRequests.id,
        reviewerId: prReviewRequests.reviewerId,
        username: users.username,
        source: prReviewRequests.source,
        state: prReviewRequests.state,
        requestedAt: prReviewRequests.requestedAt,
        resolvedAt: prReviewRequests.resolvedAt,
      })
      .from(prReviewRequests)
      .innerJoin(users, eq(users.id, prReviewRequests.reviewerId))
      .where(eq(prReviewRequests.pullRequestId, pullRequestId))
      .orderBy(prReviewRequests.requestedAt);
    return rows.map((r) => ({
      ...r,
      source: r.source as ReviewSource,
      state: r.state as ReviewState,
    }));
  } catch (err) {
    console.error("[review-requests] listForPr failed:", err);
    return [];
  }
}

/** Dismiss a request (e.g. reviewer removed by maintainer). Idempotent. */
export async function dismissRequest(
  pullRequestId: string,
  reviewerId: string
): Promise<boolean> {
  try {
    const res = await db
      .update(prReviewRequests)
      .set({ state: "dismissed", resolvedAt: new Date() })
      .where(
        and(
          eq(prReviewRequests.pullRequestId, pullRequestId),
          eq(prReviewRequests.reviewerId, reviewerId)
        )
      )
      .returning({ id: prReviewRequests.id });
    return res.length > 0;
  } catch (err) {
    console.error("[review-requests] dismissRequest failed:", err);
    return false;
  }
}

/**
 * Mark a reviewer's request as resolved when they submit a review. Called
 * by the PR review handler. `commented` leaves the request in `pending`.
 */
export async function recordReviewOutcome(
  pullRequestId: string,
  reviewerId: string,
  outcome: "approved" | "changes_requested" | "commented" | "dismissed"
): Promise<void> {
  try {
    const [row] = await db
      .select()
      .from(prReviewRequests)
      .where(
        and(
          eq(prReviewRequests.pullRequestId, pullRequestId),
          eq(prReviewRequests.reviewerId, reviewerId)
        )
      )
      .limit(1);
    if (!row) return; // reviewer wasn't requested — nothing to update
    const newState = nextState(row.state as ReviewState, outcome);
    if (newState === row.state) return;
    await db
      .update(prReviewRequests)
      .set({
        state: newState,
        resolvedAt: newState === "pending" ? null : new Date(),
      })
      .where(eq(prReviewRequests.id, row.id));
  } catch (err) {
    console.error("[review-requests] recordReviewOutcome failed:", err);
  }
}

/**
 * Core helper used by PR creation. Given a PR + changed file list, resolves
 * CODEOWNERS to usernames, maps to user IDs, and requests reviews. Never
 * throws; logs + skips on failure.
 */
export async function autoAssignFromCodeowners(opts: {
  repositoryId: string;
  pullRequestId: string;
  authorId: string;
  changedPaths: string[];
  prUrl?: string;
  prTitle?: string;
}): Promise<string[]> {
  try {
    if (opts.changedPaths.length === 0) return [];
    const usernames = await reviewersForChangedFiles(
      opts.repositoryId,
      opts.changedPaths
    );
    if (usernames.length === 0) return [];
    // Resolve usernames → user IDs in one query.
    const rows = await db
      .select({ id: users.id, username: users.username })
      .from(users)
      .where(inArray(users.username, usernames));
    const reviewerIds = rows
      .map((r) => r.id)
      .filter((id) => id !== opts.authorId);
    if (reviewerIds.length === 0) return [];
    const fresh = await requestReviewers(
      opts.pullRequestId,
      reviewerIds,
      null,
      "codeowners"
    );
    // Fire-and-forget notifications.
    for (const rid of fresh) {
      notify(rid, {
        kind: "review_requested",
        title: opts.prTitle
          ? `Review requested: ${opts.prTitle}`
          : "Review requested",
        body: "CODEOWNERS auto-assigned you to review this pull request.",
        url: opts.prUrl,
      }).catch(() => {});
    }
    return fresh;
  } catch (err) {
    console.error("[review-requests] autoAssignFromCodeowners failed:", err);
    return [];
  }
}

/**
 * Count pending review requests for a user. Useful for dashboard badges.
 */
export async function countPendingForUser(userId: string): Promise<number> {
  try {
    const [row] = await db
      .select({ n: sql<number>`count(*)::int` })
      .from(prReviewRequests)
      .where(
        and(
          eq(prReviewRequests.reviewerId, userId),
          eq(prReviewRequests.state, "pending")
        )
      );
    return Number(row?.n || 0);
  } catch {
    return 0;
  }
}

export const __internal = { sanitiseCandidates, nextState };