CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 | /**
* Tests for spec-to-PR v2, part 2 — the Claude call + response parser.
*
* The Anthropic SDK captures `globalThis.fetch` at client construction, so
* every test that installs a stub must first call `_resetClientForTests()`.
*/
import { afterEach, beforeEach, describe, expect, it } from "bun:test";
import {
_resetClientForTests,
generateSpecEdits,
isForbiddenPath,
parseAiJsonResponse,
validateEdit,
} from "../lib/spec-ai";
const origFetch = globalThis.fetch;
const origKey = process.env.ANTHROPIC_API_KEY;
/**
* Install a fake fetch that returns a single Anthropic-shaped messages.create
* response with the provided text body.
*/
function installAnthropicFetch(textBody: string | (() => string)): void {
// @ts-expect-error — override global fetch for the duration of the test
globalThis.fetch = async (
_input: RequestInfo | URL,
_init: RequestInit = {}
): Promise<Response> => {
const text = typeof textBody === "function" ? textBody() : textBody;
const payload = {
id: "msg_test",
type: "message",
role: "assistant",
model: "claude-sonnet-4-6",
content: [{ type: "text", text }],
stop_reason: "end_turn",
stop_sequence: null,
usage: { input_tokens: 1, output_tokens: 1 },
};
return new Response(JSON.stringify(payload), {
status: 200,
headers: { "content-type": "application/json" },
});
};
}
function restoreEnv(): void {
globalThis.fetch = origFetch;
if (origKey === undefined) {
delete process.env.ANTHROPIC_API_KEY;
} else {
process.env.ANTHROPIC_API_KEY = origKey;
}
_resetClientForTests();
}
// ---------------------------------------------------------------------------
// Pure helpers — quick sanity checks alongside the main 4 tests.
// ---------------------------------------------------------------------------
describe("lib/spec-ai — pure helpers", () => {
it("isForbiddenPath flags locked files", () => {
expect(isForbiddenPath("BUILD_BIBLE.md")).toBe(true);
expect(isForbiddenPath("src/views/layout.tsx")).toBe(true);
expect(isForbiddenPath("drizzle/0001_init.sql")).toBe(true);
expect(isForbiddenPath("legal/terms.md")).toBe(true);
expect(isForbiddenPath("LICENSE")).toBe(true);
expect(isForbiddenPath(".github/workflows/ci.yml")).toBe(true);
});
it("isForbiddenPath lets ordinary source paths through", () => {
expect(isForbiddenPath("src/lib/foo.ts")).toBe(false);
expect(isForbiddenPath("src/routes/api.ts")).toBe(false);
});
it("validateEdit rejects unsafe paths", () => {
expect(validateEdit({ action: "edit", path: "/etc/passwd", content: "" })).toBe(false);
expect(validateEdit({ action: "edit", path: "../foo", content: "" })).toBe(false);
expect(validateEdit({ action: "edit", path: "", content: "" })).toBe(false);
});
it("validateEdit accepts a well-formed edit", () => {
expect(
validateEdit({ action: "edit", path: "src/lib/foo.ts", content: "x" })
).toBe(true);
expect(
validateEdit({ action: "delete", path: "src/old.ts" })
).toBe(true);
});
it("parseAiJsonResponse strips ```json fences", () => {
const parsed = parseAiJsonResponse('```json\n{"a":1}\n```');
expect(parsed).toEqual({ a: 1 });
});
it("parseAiJsonResponse parses raw JSON", () => {
const parsed = parseAiJsonResponse('{"b":2}');
expect(parsed).toEqual({ b: 2 });
});
it("parseAiJsonResponse returns null on garbage", () => {
expect(parseAiJsonResponse("not json at all")).toBeNull();
});
});
// ---------------------------------------------------------------------------
// The 4 required tests.
// ---------------------------------------------------------------------------
describe("lib/spec-ai — generateSpecEdits", () => {
beforeEach(() => {
_resetClientForTests();
});
afterEach(() => {
restoreEnv();
});
it("returns ok:false when ANTHROPIC_API_KEY missing", async () => {
delete process.env.ANTHROPIC_API_KEY;
const result = await generateSpecEdits({
spec: "add a greeting function",
fileList: ["src/index.ts"],
relevantFiles: [{ path: "src/index.ts", content: "// hi" }],
defaultBranch: "main",
});
expect(result.ok).toBe(false);
if (result.ok === false) {
expect(result.error).toContain("ANTHROPIC_API_KEY");
}
});
it("parses a well-formed response", async () => {
process.env.ANTHROPIC_API_KEY = "test-key";
installAnthropicFetch(
JSON.stringify({
summary: "add greet()",
edits: [
{
action: "create",
path: "src/lib/greet.ts",
content: "export const greet = () => 'hi';",
},
{
action: "edit",
path: "src/index.ts",
content: "import { greet } from './lib/greet';\ngreet();",
},
{ action: "delete", path: "src/old.ts" },
],
})
);
const result = await generateSpecEdits({
spec: "add a greeting",
fileList: ["src/index.ts"],
relevantFiles: [{ path: "src/index.ts", content: "// hi" }],
defaultBranch: "main",
});
expect(result.ok).toBe(true);
if (result.ok === true) {
expect(result.summary).toBe("add greet()");
expect(result.edits).toHaveLength(3);
expect(result.edits[0]).toEqual({
action: "create",
path: "src/lib/greet.ts",
content: "export const greet = () => 'hi';",
});
expect(result.edits[2]).toEqual({ action: "delete", path: "src/old.ts" });
}
});
// We chose "drop the forbidden edit, keep the ok:true envelope" — the
// caller can compare input vs output length if they want to detect this.
// If Claude proposes ONLY forbidden edits, the caller receives
// `{ok:true, edits:[], summary:"AI proposed no changes"}`.
it("rejects edits targeting forbidden paths (silently dropped)", async () => {
process.env.ANTHROPIC_API_KEY = "test-key";
installAnthropicFetch(
JSON.stringify({
summary: "mixed forbidden + allowed",
edits: [
{
action: "edit",
path: "BUILD_BIBLE.md",
content: "should be dropped",
},
{
action: "edit",
path: "src/views/layout.tsx",
content: "should also be dropped",
},
{
action: "edit",
path: "drizzle/0001_init.sql",
content: "dropped",
},
{
action: "edit",
path: "LICENSE",
content: "dropped",
},
{
action: "edit",
path: ".github/workflows/ci.yml",
content: "dropped",
},
{
action: "create",
path: "src/lib/ok.ts",
content: "export const ok = 1;",
},
],
})
);
const result = await generateSpecEdits({
spec: "touch forbidden files",
fileList: ["BUILD_BIBLE.md", "LICENSE"],
relevantFiles: [],
defaultBranch: "main",
});
expect(result.ok).toBe(true);
if (result.ok === true) {
// Exactly one allowed edit survives.
expect(result.edits).toHaveLength(1);
expect(result.edits[0].path).toBe("src/lib/ok.ts");
// No edit points at a forbidden path.
for (const e of result.edits) {
expect(isForbiddenPath(e.path)).toBe(false);
}
}
});
it("handles malformed JSON response", async () => {
process.env.ANTHROPIC_API_KEY = "test-key";
installAnthropicFetch("this is not JSON, sorry");
const result = await generateSpecEdits({
spec: "whatever",
fileList: [],
relevantFiles: [],
defaultBranch: "main",
});
expect(result.ok).toBe(false);
if (result.ok === false) {
expect(result.error).toBe("AI returned invalid JSON");
}
});
});
|