Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesDiscussionsWikiPull RequestsProjectsCommitsActionsReleasesContributorsPulse● GatesSecuritySettingsDeploymentsPipelineInsightsAgents✨ Explain✨ Ask AI✨ Workspace✨ Spec✨ Tests▓ Debt Map✨ NL Search🏛 Archaeology
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepgatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
workflow-secrets.ts8.0 KB · 239 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
/**
 * Workflow secrets — DB-backed CRUD + runtime context loader.
 *
 * Sibling to `workflow-secrets-crypto.ts`, which owns the pure AES-256-GCM
 * primitives. This file is the *only* place outside the runner that touches
 * `workflowSecrets` rows. All public fns follow the project-wide
 * `{ok:true,...}` / `{ok:false,error}` contract and never throw — DB errors
 * are caught and collapsed to a terse error string.
 *
 * Callers:
 *   - Agent 7 (settings UI) uses `listRepoSecrets`, `upsertRepoSecret`,
 *     `deleteRepoSecret` to render + mutate the per-repo secrets table.
 *   - Agent 5 (workflow runner) calls `loadSecretsContext` once at run start
 *     to build the `{ NAME: plaintext }` map that feeds
 *     `substituteSecrets(template, secrets)` for every step's `run:` / `env:`.
 *
 * Security notes:
 *   - `listRepoSecrets` never returns plaintext or ciphertext — UI only sees
 *     metadata (name, createdAt, createdBy).
 *   - `deleteRepoSecret` is scoped on both (repoId, secretId) to prevent a
 *     caller with one repo's context from deleting another repo's secret by
 *     guessing a UUID.
 *   - `loadSecretsContext` silently omits secrets whose decryption fails so
 *     the `${{ secrets.NAME }}` template left intact in logs — that's a louder
 *     failure signal than substituting empty string.
 */

import { and, asc, eq } from "drizzle-orm";
import { db } from "../db";
import { workflowSecrets } from "../db/schema";
import { decryptSecret, encryptSecret, getMasterKey } from "./workflow-secrets-crypto";

/** Matches GitHub Actions secret-name rules: uppercase + digits + underscore,
 * must not start with a digit, max 100 chars. Case is enforced strictly. */
const SECRET_NAME_RE = /^[A-Z_][A-Z0-9_]*$/;
const MAX_NAME_LEN = 100;

export type SecretMetadata = {
  id: string;
  name: string;
  createdAt: Date;
  createdBy: string | null;
};

/**
 * List a repository's secrets — metadata only.
 *
 * Returns rows ordered by `name` ascending. Plaintext and ciphertext are
 * deliberately excluded so this fn is safe to call from a web handler that
 * renders the settings page.
 */
export async function listRepoSecrets(
  repoId: string
): Promise<
  | { ok: true; secrets: SecretMetadata[] }
  | { ok: false; error: string }
> {
  if (typeof repoId !== "string" || repoId.length === 0) {
    return { ok: false, error: "repoId is required" };
  }
  try {
    const rows = await db
      .select({
        id: workflowSecrets.id,
        name: workflowSecrets.name,
        createdAt: workflowSecrets.createdAt,
        createdBy: workflowSecrets.createdBy,
      })
      .from(workflowSecrets)
      .where(eq(workflowSecrets.repositoryId, repoId))
      .orderBy(asc(workflowSecrets.name));
    return { ok: true, secrets: rows };
  } catch (err) {
    console.error("[workflow-secrets] listRepoSecrets:", err);
    return { ok: false, error: "db query failed" };
  }
}

/**
 * Create or update a repository secret. Name must match `[A-Z_][A-Z0-9_]*`
 * (max 100 chars) and value is encrypted under the master key before being
 * written. On conflict (repo+name already exists) the existing row is
 * replaced and its `updated_at` bumped; `created_at` and `created_by` stay
 * pinned to the original insert for audit history.
 */
export async function upsertRepoSecret(args: {
  repoId: string;
  name: string;
  value: string;
  createdBy: string;
}): Promise<{ ok: true; id: string } | { ok: false; error: string }> {
  const { repoId, name, value, createdBy } = args;
  if (typeof repoId !== "string" || repoId.length === 0) {
    return { ok: false, error: "repoId is required" };
  }
  if (typeof createdBy !== "string" || createdBy.length === 0) {
    return { ok: false, error: "createdBy is required" };
  }
  if (typeof name !== "string" || name.length === 0) {
    return { ok: false, error: "name is required" };
  }
  if (name.length > MAX_NAME_LEN) {
    return { ok: false, error: `name must be <= ${MAX_NAME_LEN} chars` };
  }
  if (!SECRET_NAME_RE.test(name)) {
    return {
      ok: false,
      error: "name must match /^[A-Z_][A-Z0-9_]*$/ (uppercase, digits, underscore; not leading digit)",
    };
  }
  if (typeof value !== "string") {
    return { ok: false, error: "value must be a string" };
  }

  const enc = encryptSecret(value);
  if (!enc.ok) return { ok: false, error: enc.error };

  try {
    const rows = await db
      .insert(workflowSecrets)
      .values({
        repositoryId: repoId,
        name,
        encryptedValue: enc.ciphertext,
        createdBy,
      })
      .onConflictDoUpdate({
        target: [workflowSecrets.repositoryId, workflowSecrets.name],
        set: {
          encryptedValue: enc.ciphertext,
          updatedAt: new Date(),
        },
      })
      .returning({ id: workflowSecrets.id });
    const id = rows[0]?.id;
    if (!id) return { ok: false, error: "insert returned no row" };
    return { ok: true, id };
  } catch (err) {
    console.error("[workflow-secrets] upsertRepoSecret:", err);
    return {
      ok: false,
      error: `db write failed: ${err instanceof Error ? err.message : String(err)}`,
    };
  }
}

/**
 * Delete a single secret by id, scoped to its repository. Both filters must
 * match — this is defence-in-depth against a caller that has a secretId but
 * the wrong repo context (e.g. path-param manipulation).
 *
 * Returns `{ok:true}` even if no row matched; the caller can't distinguish
 * "deleted" from "never existed" and that's fine for an idempotent DELETE.
 */
export async function deleteRepoSecret(args: {
  repoId: string;
  secretId: string;
}): Promise<{ ok: true } | { ok: false; error: string }> {
  const { repoId, secretId } = args;
  if (typeof repoId !== "string" || repoId.length === 0) {
    return { ok: false, error: "repoId is required" };
  }
  if (typeof secretId !== "string" || secretId.length === 0) {
    return { ok: false, error: "secretId is required" };
  }
  try {
    await db
      .delete(workflowSecrets)
      .where(
        and(
          eq(workflowSecrets.id, secretId),
          eq(workflowSecrets.repositoryId, repoId)
        )
      );
    return { ok: true };
  } catch (err) {
    console.error("[workflow-secrets] deleteRepoSecret:", err);
    return {
      ok: false,
      error: `db delete failed: ${err instanceof Error ? err.message : String(err)}`,
    };
  }
}

/**
 * Build the `{ NAME: plaintext }` map consumed by the runner's
 * `substituteSecrets(template, secrets)` calls.
 *
 * Graceful-degrade semantics (intentional — the runner MUST NOT crash here):
 *   - Master key missing → returns `{}`. A warning is logged. Every
 *     `${{ secrets.X }}` token will pass through untouched, making the
 *     misconfiguration visible in job logs.
 *   - Individual decryption failure (tampered row, key rotated, etc.) → that
 *     secret is skipped; others still load.
 *   - DB error → returns `{}`.
 *
 * Note: this returns the raw map, not a `{ok,...}` tuple, because the runner
 * wants a hot path with no branching at call sites.
 */
export async function loadSecretsContext(
  repoId: string
): Promise<Record<string, string>> {
  if (typeof repoId !== "string" || repoId.length === 0) {
    return {};
  }
  if (!getMasterKey()) {
    console.error(
      "[workflow-secrets] loadSecretsContext: WORKFLOW_SECRETS_KEY missing; secrets will not be substituted"
    );
    return {};
  }

  let rows: { name: string; encryptedValue: string }[];
  try {
    rows = await db
      .select({
        name: workflowSecrets.name,
        encryptedValue: workflowSecrets.encryptedValue,
      })
      .from(workflowSecrets)
      .where(eq(workflowSecrets.repositoryId, repoId));
  } catch (err) {
    console.error("[workflow-secrets] loadSecretsContext db error:", err);
    return {};
  }

  const out: Record<string, string> = {};
  for (const row of rows) {
    const dec = decryptSecret(row.encryptedValue);
    if (!dec.ok) {
      console.error(
        `[workflow-secrets] decrypt failed for secret "${row.name}": ${dec.error}`
      );
      continue;
    }
    out[row.name] = dec.plaintext;
  }
  return out;
}