Pre-launch — Gluecron is in final validation. Public signups and git hosting for non-owner users open after launch review.
CodeIssuesPull RequestsActionsSecurityInsightsSettings
✨ AI
More
claude/adoring-hopper-5x74bqclaude/affectionate-feynman-ykrf1hclaude/architecture-audit-design-wxprenclaude/build-status-update-3MXsfclaude/charming-meitner-mllb5rclaude/compare-gate-gluecron-s4mFQclaude/confident-faraday-tikcwbclaude/continue-work-XMTlIclaude/crontech-gluecron-deploy-7MIECclaude/crontech-platform-setup-SeKfwclaude/design-2026claude/ecstatic-ptolemy-jMdigclaude/enhance-github-integration-QNHdGclaude/fix-aa-loop-issue-PonMQclaude/fix-actions-and-processclaude/fix-desktop-errors-XqoW8claude/fix-red-workflowsclaude/fix-website-access-6FKJNclaude/gatetest-integration-hardeningclaude/github-audit-improvements-bDFr9claude/gluecron-launch-status-FoMRlclaude/hopeful-lamport-olfCTclaude/issue-to-pr-and-protectionsclaude/jolly-heisenberg-2sg1Qclaude/launch-preparation-QmTb6claude/new-session-xk1l7claude/plan-platform-architecture-kkN4yclaude/platform-analysis-roadmap-1nUGLclaude/platform-launch-assessment-8dWV8claude/polish-platform-release-AeDrUclaude/resume-previous-work-KzyLwclaude/review-crontech-handoff-qYEVqclaude/review-project-completeness-lHhS2claude/review-readme-docs-ulqPKclaude/serene-edison-rj87weclaude/setup-multi-repo-dev-BCwNQclaude/ship-fixes-and-tests-Jvz1cclaude/site-audit-competitive-pctlwgclaude/site-migration-vercel-XstpKclaude/standalone-product-repos-XHFTDcopilot/feat-smart-empty-states-keyboard-first-enhancementcopilot/feat-smart-morning-digest-review-context-restorecopilot/fix-and-process-workflowscopilot/update-ai-powered-code-reviewfeat/debt-mapfeat/push-policy-codeowners-hardeningfeat/smart-digest-contextfeat/stage-impactfeat/t1-secret-migrationfeat/u-polishfeat/w-self-hostfeat/w2-claude-configfix/agent-journey-orphan-sweepfix/audit-sweep-2026-07-26gatetest/auto-fix-1776586424172gatetest/auto-fix-1776586534814gatetest/auto-fix-1776590685143gatetest/auto-fix-1776590808199mainops/redeploy-retriggerstyle/dxt-cta-themeworktree-agent-a3377aad30d55da26worktree-agent-a7ef607b7ee1d6c74
count-bigint.test.ts3.7 KB · 98 lines
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
/**
 * Postgres count() returns bigint, which the driver hands back as a STRING.
 *
 * Drizzle's `sql<number>` is a compile-time cast only — it does not coerce at
 * runtime — so `sql<number>`count(*)`` yields "0", not 0. Every consumer that
 * compared with === or did arithmetic was silently broken:
 *
 *   - onboarding.tsx: `repoCount === 0` is "0" === 0 → false, so the entire
 *     first-run branch was unreachable and brand-new users never saw the
 *     getting-started flow.
 *   - notifications.tsx: `unreadCount === 0` → the "You are all caught up"
 *     state could never render.
 *   - inbox.tsx: GET /api/inbox/count returned a JSON string, diverging from
 *     /api/notifications/count which returns a number.
 *   - pulls.tsx previously rendered "0"+"0"+"0" as "000" (fixed earlier).
 *
 * The established fix in this codebase is `count(*)::int` — already used at
 * 100+ sites. These stragglers are now consistent with it.
 */

import { describe, expect, it } from "bun:test";
import { readdirSync, readFileSync, statSync } from "fs";
import { join } from "path";

function walk(dir: string): string[] {
  const out: string[] = [];
  for (const e of readdirSync(dir)) {
    const p = join(dir, e);
    if (statSync(p).isDirectory()) {
      if (e === "__tests__") continue;
      out.push(...walk(p));
    } else if (e.endsWith(".ts") || e.endsWith(".tsx")) out.push(p);
  }
  return out;
}

const FILES = walk("src");

describe("no uncast bigint aggregates typed as number", () => {
  it("every sql<number>count(*) casts to ::int", () => {
    const offenders: string[] = [];
    for (const f of FILES) {
      const src = readFileSync(f, "utf8");
      src.split("\n").forEach((line, i) => {
        // Typed as number but no cast — the exact bug shape.
        if (/sql<number>`\s*count\(\*\)\s*`/.test(line)) {
          offenders.push(`${f.replace(/\\/g, "/")}:${i + 1}`);
        }
      });
    }
    expect(offenders).toEqual([]);
  });

  it("no sql<number> wraps count()/sum() of a column without a cast either", () => {
    const offenders: string[] = [];
    for (const f of FILES) {
      const src = readFileSync(f, "utf8");
      src.split("\n").forEach((line, i) => {
        const m = line.match(/sql<number>`([^`]*)`/);
        if (!m) return;
        const expr = m[1];
        if (!/\b(count|sum)\s*\(/i.test(expr)) return;
        if (expr.includes("::")) return; // cast present
        offenders.push(`${f.replace(/\\/g, "/")}:${i + 1}${expr.trim()}`);
      });
    }
    expect(offenders).toEqual([]);
  });
});

describe("the specific consumers that were broken", () => {
  it("onboarding's first-run branch can now be reached", () => {
    const src = readFileSync("src/routes/onboarding.tsx", "utf8");
    expect(src).toContain("count(*)::int");
    // The comparison itself is fine once the value is a real number.
    expect(src).toContain("repoCount === 0");
  });

  it("notifications' all-caught-up branch can now be reached", () => {
    const src = readFileSync("src/routes/notifications.tsx", "utf8");
    expect(src).toContain("count(*)::int");
    expect(src).toContain("unreadCount === 0");
  });

  it("inbox's count endpoint returns a number", () => {
    const src = readFileSync("src/routes/inbox.tsx", "utf8");
    expect(src).toContain("count(*)::int");
  });
});

describe("ORDER BY aggregates are deliberately left alone", () => {
  it("bare sql`count(*)` in an orderBy is not flagged", () => {
    // Sorting on bigint is correct; only *selected* values reach JS and need
    // the cast. Keeping these uncast avoids churn with no behaviour change.
    const pulls = readFileSync("src/routes/pulls.tsx", "utf8");
    expect(pulls).toContain("desc(sql`count(*)`)");
  });
});