fix(push): the per-repo secret-scan toggle now governs pushes, as its label claims #5621
gluecron[bot]🤖 botAI Reviewcommented 20h ago
AI review unavailable
The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.
ccantynzAI Reviewcommented 20h ago
AI Triage
(no summary)
Priority: medium Risk area: mixed
Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)
Suggestions only — nothing has been applied. The PR author stays in control.
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Owner-approved (2026-09-02), unblocking the owner-requested Vapron full-history import.
The drift
The gates settings page has always described
secretScanEnabledas "Regex + AI secret detection on every push". The merge-time gate honours it. The pre-receive hook read only the globalsecretScanOnPushDisabledkill switch and never consulted the per-repo setting — a toggle silently governing half of what it names. Same push/merge drift family as theallow-secretpragma that armed the 2026-09-01 outage.How it surfaced
The push gate (correctly) rejected the Vapron import on
secret-crypto.test.ts:123-124— verified synthetic fixtures inside a test proving their crypto module refuses plaintext. Rewriting their commits to carry our pragma would fork them from their canonical history, so the sanctioned route is the toggle the UI already promises — and the only switch that actually worked was platform-wide: the wrong blast radius by exactly one platform.The fix
getOrCreateSettings(repositoryId).secretScanEnabled; both switches ANDed.Operational sequence this enables
Toggle one repo off → push the import → toggle back on. Every repo's default, and this one's end state, remains scanning.
Verification